[Scons-dev] Remaining Buildbot errors under Windows...

[Bill Deegan]

Dirk,

Yup. I saw both those failures from my last batch of compat removals.
I've been looking if there was a reasonable way to keep that option-j test,
but sounds like you also agree there isn't.
I'll take a look at them later today.

-Bill

On Wed, Dec 16, 2015 at 2:49 PM, Dirk Bächle <tshortik at gmx.de> wrote:

> Hi all,
>
> after my last commit, the Windows Buildbot has only two remaining
> errors/fails, namely:
>
>         test\SWIG\SWIG.py
>         test\option-j.py
>
> . I analysed these a little, and here are my results:
>
> test\SWIG\SWIG.py
> =================
>
> The version number $SWIGVERSION gets wrong. Is there a "swig" installed on
> the Windows machine already? If yes, does it support "-version"?
>
>
> test\option-j.py
> ================
>
> Goes back to "build250" (revision 95b942cb8718,
> https://bitbucket.org/scons/scons/changeset/95b942cb8718/), where the
> compat wrapper for the subprocess module was removed. In this test, a fake
> "threading.py" is added to the working dir, such that the initialization of
> the Jobs/Worker stuff should fail when trying to "import threading" and
> should emit a warning that parallel processing is not supported on this
> platform.
> Unfortunately, we import subprocess in a lot of places and Action.py is no
> exception. This import happens earlier, and now throws an unexpected
> ImportError, because the compat module isn't there anymore.
> Here's the start of subprocess.py on my system (Ubuntu Linux 14.04 LTS
> with Python 2.7.6):
>
>
> import sys
> mswindows = (sys.platform == "win32")
>
> if mswindows:
>     import threading
>     import msvcrt
>     import _subprocess
>     class STARTUPINFO:
>         dwFlags = 0
>         hStdInput = None
>         hStdOutput = None
>         hStdError = None
>         wShowWindow = 0
>     class pywintypes:
>         error = IOError
> else:
>     import select
>     _has_poll = hasattr(select, 'poll')
>     import fcntl
>     import pickle
>
>
> It shows why the test doesn't fail under Linux, subprocess.py imports
> "threading" only under MSWindows.
>
>
> Leaves us with the question what to do about those two. Comments?
> Volunteers?
>
> Best regards,
>
> Dirk
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20151216/3f1d9106/attachment.html>