[Scons-dev] PR 3155

Bill Deegan bill at baddogconsulting.com
Tue Jul 24 11:19:56 EDT 2018


I put some feedback on the PR almost as soon as you submitted it that you
have yet to respond to.

We need a test which fails under normal scons before your changes and
passes after, as we do with pretty much any and all pull requests.

-Bill

On Mon, Jul 23, 2018 at 5:42 PM, Jason Kenny <dragon512 at live.com> wrote:

> Hi Bill,
>
>
>
> Wanted to know what are your concerns about PR 3155. It current addresses
> and fixes a number of small issues ( mostly on windows) the pass rate is
> better.
>
>
>
> Any reason for not merging this?
>
>
>
> Jason
>
> _______________________________________________
> Scons-dev mailing list
> Scons-dev at scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist2.pair.net/pipermail/scons-dev/attachments/20180724/8eafb8eb/attachment.html>


More information about the Scons-dev mailing list