[Scons-dev] 2.3.3 Release issue ?

[anatoly techtonik]

On Mon, Sep 8, 2014 at 7:41 PM, Alexandre Feblot <alexandre at feblot.fr> wrote:
> Hi,
>
> Would there be a release issue with 2.3.3 ?
>
> Downloaded from http://prdownloads.sourceforge.net/scons/scons-2.3.3.tar.gz
>
> Installed by python setup.py install --prefix /usr/local --optimize 2
> --symlink-scons
>
> scons --version
> SCons by Steven Knight et al.:
>     script: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu
>     engine: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu
>     engine path: ['/usr/local/lib/scons-2.3.3/SCons']
> Copyright (c) 2001 - 2014 The SCons Foundation
>
>
> EnsureSConsVersion() just prints:
>
> scons: warning: EnsureSConsVersion is ignored for development version

Yes. This is a bug:

   def EnsureSConsVersion(self, major, minor, revision=0):
       """Exit abnormally if the SCons version is not late enough."""
       if SCons.__version__ == '2.3.3':
           SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning,

This should be:

   def EnsureSConsVersion(self, major, minor, revision=0):
       """Exit abnormally if the SCons version is not late enough."""
       if SCons.__version__ == '__VERSION__':
           SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning,

The __VERSION__ of course was replaced during our build process. The
quick fix is:
-       if SCons.__version__ == '__VERSION__':
+       if SCons.__version__ == '__' + 'VERSION__':