[Scons-dev] Question about .../SCons/Platform/win32.py

[getspammed]

Hello Anatoly,

thank you for your investigations.

After reading issue 1721 i realized that:

  - my assumption, that msvcrt defaulted to open files as non inheritable was false.
  - python2's implementation of 'open' seems to use the c runtime's default behaviour (creating inheritable handles).
  - python3's new io module does it differently and creates non inheritable handles.

I was asking my question, since i am using a bare python3 installation without pywin32 installed, which gave me
warnings about parallel builds. So my conclusion is:

  - The code in win32.py is a workaround for a problem that can be triggered when using python2. Therefore giving a warning is appropriate in that case.
  - When running under python3 the warning can be ignored. It would be even better if that warning was suppressed in that case.

Regards,
Rocco



Am 23.03.2014 08:39, schrieb anatoly techtonik:

> Hi Rocco,

>

> Sorry for a long delay. It took time to dig this, which was:

>

> 1. open https://bitbucket.org/scons/scons/src/tip/src/engine/SCons/Platform/win32.py?at=default

> 2. hit blame button

> 3. look through

> https://bitbucket.org/scons/scons/commits/99b456bb216afb8eee1e49a0002534d2bf37fb65

> 4. search for Windows

> 5. find reference to issue 1721

>

> http://scons.tigris.org/ds/viewMessage.do?dsForumId=1271&dsMessageId=918750

>

>> So my questions are:

>> Why is that code there?

>> Does it handle situations (different OS or python interpreter) that i didn't

>> think of?

>

> It may worth checking the issue thread to get the details and see if that

> is already fixed. It would help to provide a better test and to issue on

> http://bugs.python.org if behavior is confirmed.

>