[Scons-dev] SCons and octal constants
anatoly techtonik
techtonik at gmail.com
Mon Apr 28 03:19:23 EDT 2014
On Mon, Apr 28, 2014 at 8:48 AM, Russel Winder <russel at winder.org.uk> wrote:
> Since the floor version of SCons is now Python 2.7, we should dispense
> with the horror that is 1970s C-style octal constants and use the 0o
> form (*). This applies to the default/default branch just as much to the
> default/python3-port branch (where it is needed for SCons to run at all
> on Python 3).
>
> If making this change is agreed then I guess there needs to be a single
> changeset alteration proposed to both branches. I am assuming we do this
> on one branch and then cherry-pick into the other. This would imply
> doing it for the default/default branch and then cherry-picking into
> default/python3-port.
>
> Thanks.
>
> (*) The 0o form works in Python 2.6 as well.
Let me sum this up. To make SCons codebase more 2/3 compatible, we
need to use 0o777 instead of 0777.
+1
Do you need help preparing PR?
BTW, does anybody know a tool to grep Python AST for that?
Maybe pylint with a single rule can do all the job automatically?
Would be nice to see the command here for reference.
--
anatoly t.
More information about the Scons-dev
mailing list