[Scons-dev] Subprocess issue on Linux?

[Leskinen, Eugene]

Hi Dirk,

Thank you for testing the stuff. I have re-produced and fixed the issue. Please try the latest version of stubprocess.py

-----Original Message-----
From: scons-dev-bounces at scons.org [mailto:scons-dev-bounces at scons.org] On Behalf Of Dirk Bachle
Sent: Wednesday, April 09, 2014 11:28 PM
To: SCons developer list
Subject: Re: [Scons-dev] Subprocess issue on Linux?

On 09.04.2014 19:24, Bill Deegan wrote:

> Dirk,

>

> That's pretty impressive!

> Does it pass the full regression suite?

>


No, it doesn't work:

501/1110 (45.14%) /usr/bin/python -tt test/LEX/live.py /home/dirk/workspace/scons_dirkbaechle/src/script/scons.py returned 2 STDOUT =========================================================================
scons: Reading SConscript files ...

STDERR
=========================================================================
KeyError: 'PATH':
   File "/tmp/testcmd.4854.Zu6ZsJ/SConstruct", line 2:
     foo = Environment()
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Environment.py",
line 1003:
     apply_tools(self, tools, toolpath)
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Environment.py",
line 107:
     env.Tool(tool)
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Environment.py",
line 1787:
     tool(self)
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Tool/__init__.py",
line 183:
     self.generate(env, *args, **kw)
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Tool/default.py",
line 40:
     for t in SCons.Tool.tool_list(env['PLATFORM'], env):
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Tool/__init__.py",
line 819:
     ], env)
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Tool/__init__.py",
line 690:
     return list(filter (ToolExists, tools))
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Tool/__init__.py",
line 689:
     return Tool(tool).exists(env)
   File
"/home/dirk/workspace/scons_dirkbaechle/src/script/../engine/SCons/Tool/wix.py",
line 71:
     for path in os.environ['PATH'].split(os.pathsep):
   File "/usr/lib/python2.7/UserDict.py", line 23:
     raise KeyError(key)

FAILED test of /home/dirk/workspace/scons_dirkbaechle/src/script/scons.py


Looks like the wrapping of Subprocess.Popen in stubprocess.py prevents the os.environ settings to get through, so all tests that setup a simple Environment and auto-detect Tools are bound to fail. :(

Dirk

_______________________________________________
Scons-dev mailing list
Scons-dev at scons.org
http://two.pairlist.net/mailman/listinfo/scons-dev

--------------------------------------------------------------------
Closed Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park, 
17 Krylatskaya Str., Bldg 4, Moscow 121614, 
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stubprocess.py
Type: application/octet-stream
Size: 11871 bytes
Desc: stubprocess.py
Url : <http://two.pairlist.net/pipermail/scons-dev/attachments/20140410/dd0aee3a/attachment-0001.obj>