[Scons-dev] Fwd: [Bitbucket] Pull request #84: cyglink tool (scons/scons)

[Manuel Naranjo]

I had been using it this week (the one provided by cygwin, not sure if 
it's exactly the same version), there are a couple of bugs that I have 
fixed, I'll pull the patch and apply my changes.

+    pre = env.subst('$SHLIBPREFIX')
+    dll_name = str(dll)
+    if dll_name[len(pre):len(pre)+3] == 'lib':
+        dll_name = pre + dll_name[len(pre)+3:]
+        dll = env.fs.File(dll_name)

That dll_name = str(dll) line is wrong, I have changed it for dll.name 
and then dll = env.fs.File(dll_name) with dll.name = dllName otherwise 
the node gets changed and variant-dir are not honored.



> This looks like a very useful patch for building under cygwin python

> with cygwin GNU tools.  I don't have a cygwin python system handy; can

> any cygwin users on this list confirm that this patch works, passes

> tests and seems otherwise OK?

>

> -- Gary

>

> ---------- Forwarded message ----------

> From: *David Rothenberger* <pullrequests-reply at bitbucket.org

> <mailto:pullrequests-reply at bitbucket.org>>

> Date: Sun, Aug 18, 2013 at 12:03 AM

> Subject: [Bitbucket] Pull request #84: cyglink tool (scons/scons)

> To: garyo at oberbrunner.com <mailto:garyo at oberbrunner.com>

>

>

> __

> drothenberger 	

> *David Rothenberger* created pull request #84:

> cyglink tool

> <https://bitbucket.org/scons/scons/pull-request/84/cyglink-tool>

>

> These commits add Tools/cyglink.py, a specialization of gnulink.py that

> uses Cygwin naming conventions for shared libraries and automatically

> generates import libraries.

>

> Author 	Commit 	Message 	Date

> drothenbergerDavid Rothenberger 	c4b3106

> <https://bitbucket.org/drothenberger/cygwin_link/commits/c4b3106c57d2b9bd4f56286bf17baeb50164f109>

> 	Fix Libs/SharedLibraryIxes.py 	18 Aug 2013

> drothenbergerDavid Rothenberger 	4c5a4db

> <https://bitbucket.org/drothenberger/cygwin_link/commits/4c5a4db87c364504745e5cfe1b10ac4f3e6d5118>

> 	Fix Libs/SharedLibrary.py 	18 Aug 2013

> drothenbergerDavid Rothenberger 	95abac1

> <https://bitbucket.org/drothenberger/cygwin_link/commits/95abac10546e4f2f6a1a426070d085dfe248812f>

> 	Fix VersionedLib test 	18 Aug 2013

> drothenbergerDavid Rothenberger 	dd9ee3c

> <https://bitbucket.org/drothenberger/cygwin_link/commits/dd9ee3c50119da22f3c444d58720573302b6e633>

> 	Add a cyglink tool 	17 Aug 2013

>

> View this pull request

> <https://bitbucket.org/scons/scons/pull-request/84/cyglink-tool> or add

> a comment by replying to this email.

>

> Unsubscribe from pull request emails

> <https://bitbucket.org/scons/scons/pull-request/84/unsubscribe/garyo/56bed7d2446924154d53a52a7577f2b2458ab9cd/>

> for this repository. 		Bitbucket <https://bitbucket.org>

>

>

>

>

> --

> Gary

>

>

> _______________________________________________

> Scons-dev mailing list

> Scons-dev at scons.org

> http://two.pairlist.net/mailman/listinfo/scons-dev

>