[Scons-dev] RPM helper functions, where should they go?

[Dirk Bächle]

On 25.09.2012 20:03, Gary Oberbrunner wrote:

> On Tue, Sep 25, 2012 at 1:38 PM, Dirk Bächle<tshortik at gmx.de>  wrote:

>> Hi there,

>>

>> for fixing the current Buildbot failures I still have to fight down several

>> RPM tests. They check the names of the created RPM files

> I think many of the current tests are way too strict in how they test

> the build output.  They could achieve the same goals (success/failure)

> but be a lot more resistant to path changes, drive name changes and

> even language changes if we just check the output for certain key

> words.  Plus it makes the tests simpler to create and maintain.  Would

> that help here?


We'll probably end there anyhow, once the number of Buildslaves is going 
up again. ;)
Right now, the showstopper is the check in line 89 of SCons/Tool/rpm.py.
Should I rather remove it, instead of mimicking all the RPM stuff?


>> My suggestion would be a new file "rpmrc.py" in the SCons/Tools dir,

>> alongside the "rpm.py" tool.

>> Does this make sense or do we have a better place?

> I think since it is tool-specific, putting it in SCons/Tools is best

> -- it shouldn't go up in the core.  You could call it rpmutils.py

> perhaps?


I called it "rpmrc", because that's the name of the file in the RPM 
sources. But "rpmutils" would be fine with me too.


>> P.S.: For cases like this it would be cool to have a "scons-common" package

>> with stuff that can get used by SCons itself, the test framework and perhaps

>> even Parts. It could offer basic things like "starting processes,

>> is-this-a-list?" and similar stuff, which are partly spread over the whole

>> codebase in different variations...

> Util.py has some of this, but indeed not all of it.  In my experience,

> trying to define what's "basic" in your sense above is trickier than

> it seems.  But I also agree there is some duplication that should be

> eliminated -- not all that much though, right?

>


Yes, I think we're still good with what we have right now. It was more 
like a mental note to myself, just thinking out loud. While skimming 
through all the test stuff and the source, I stumbled over a few places 
and had a little deja-vu experience...that's all.

Regards,

Dirk