[Scons-dev] TEMPFILE spaces bug: your thoughts requested

[Kenny, Jason L]

We gave Steve the patch to this issue.. As I recall he did not take it 100% and changed it. I have updated that version here:

http://parts.tigris.org/source/browse/*checkout*/parts/trunk/parts/parts/mappers.py?revision=449&content-type=text%2Fplain

end of the file line 694-800

As I recall Steve tweak the actions to help make it smarter ( I believe it was the addition of a print action value), to help separate the value the temp file will call from the case when it need to create the temp file

I forget the tweak we made, but it fixed the generation issue we found in our builds. I believe the issue is fixed with left overs lnk files in the temp directory. We use TempFile heavily in Part, or tweak the mslink and msvc tool use TEMPFILEMUNGE to deal with CC CXX and LINK commands as we found cases in our build in which the command line of these go way to long.

The issue in 1705 I have not seen in our usages of it with scon 2.1 or 2.2, however in Parts we override the SPAWN function to use subprocess. One other tweak is to not use the escape functions as it break windows. I can try to look at this bug as I general familiar with the issues with tempfilemunge class

Jason


-----Original Message-----
From: scons-dev-bounces at scons.org [mailto:scons-dev-bounces at scons.org] On Behalf Of Gary Oberbrunner
Sent: Saturday, September 01, 2012 5:57 PM
To: SCons Dev List
Subject: [Scons-dev] TEMPFILE spaces bug: your thoughts requested

Check out http://scons.tigris.org/issues/show_bug.cgi?id=1705.  It's possible for the TEMPFILE logic to get confused if the command has spaces in its path.  The proposed solution in the bug goes a bit beyond that, introducing a new kind of variable substition: $"FOO"
(i.e. with quotes around it).  The semantics are, if I understand the patch, that it gets one level of substitution but no more.

Question for you all: does this seem like a good enhancement?  Any simpler ways to fix the actual bug you can think of?  If we do this, I'd have to write tests and doc which I'm happy to do but want to spend the time most effectively.

--
Gary
_______________________________________________
Scons-dev mailing list
Scons-dev at scons.org
http://two.pairlist.net/mailman/listinfo/scons-dev